fabiomontefuscolo/side-notes
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat: focus editor and restore caret/scroll on note load

Browse source
This commit is contained in:
Fabio Montefuscolo 2026-08-03 22:13:01 +02:00
parent fbabcdf750
commit c58d13eafa
2 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
openspec/changes/sidepanel-ux-improvements/tasks.md
View file

@ -13,7 +13,7 @@
## 3. Focus and caret/scroll restore ## 3. Focus and caret/scroll restore
- [ ] 3.1 In `loadNoteForTab`, after setting `editor.value`, restore caret via `setSelectionRange` with offsets clamped to content length (default 0 for legacy records), restore `scrollTop` (in `requestAnimationFrame` if layout timing clamps it), and call `editor.focus()` - [x] 3.1 In `loadNoteForTab`, after setting `editor.value`, restore caret via `setSelectionRange` with offsets clamped to content length (default 0 for legacy records), restore `scrollTop` (in `requestAnimationFrame` if layout timing clamps it), and call `editor.focus()`
- [ ] 3.2 Make `reloadFromDB` skip the `editor.value` assignment when fetched content is identical, so remote saves never move the local caret unnecessarily - [ ] 3.2 Make `reloadFromDB` skip the `editor.value` assignment when fetched content is identical, so remote saves never move the local caret unnecessarily
- [ ] 3.3 Manually verify focus lands when the panel opens via toolbar action and via keyboard shortcut; caret restore works on panel open, tab switch, and SPA navigation - [ ] 3.3 Manually verify focus lands when the panel opens via toolbar action and via keyboard shortcut; caret restore works on panel open, tab switch, and SPA navigation

13
sidepanel/sidepanel.js
View file

@ -100,6 +100,19 @@ async function loadNoteForTab(tabId) {
editor.value = note ? note.content : ''; editor.value = note ? note.content : '';
isLoadingContent = false; isLoadingContent = false;
// Restore caret and scroll position, clamped to the current content
// length (another panel may have shortened the note since the position
// was saved). Records saved before caret persistence default to 0.
const len = editor.value.length;
const start = Math.min(note?.caretStart ?? 0, len);
const end = Math.min(note?.caretEnd ?? start, len);
editor.setSelectionRange(start, end);
const savedScrollTop = note?.scrollTop ?? 0;
requestAnimationFrame(() => {
editor.scrollTop = savedScrollTop;
});
editor.focus();
updateStatus('Saved'); updateStatus('Saved');
} catch (err) { } catch (err) {
console.error('Side Notes: failed to load note for tab', tabId, err); console.error('Side Notes: failed to load note for tab', tabId, err);